fix(hub): align tests, example & API snapshots with dropped ~builtin category default#95
Merged
Conversation
…in category default Commit 1223160 removed the hub's withBuiltinCategory auto-defaulting so callers declare the ~builtin category themselves, but left the host-docks test, the minimal-next example, and the tsnapi snapshots asserting the old behavior. Update them to match: the hub preserves the caller-supplied category untouched.
✅ Deploy Preview for devfra ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
CI on
mainis red. Commit `1223160` ("fix(hub): relex builtin views ids") intentionally removed the hub's `withBuiltinCategory` auto-defaulting, shifting the responsibility for declaring the `~builtin` category to the callers themselves (as the follow-up `6d1bb4f` does for the inspect/messages/terminals plugins). That change left three artifacts asserting the old behavior, breaking the unit-test job across every OS/Node matrix:What
Full suite green locally: `pnpm lint && pnpm test && pnpm typecheck && pnpm build` (651 tests pass).
This PR was created with the help of an agent.